Fix ssz formatting for /light_client/updates beacon API endpoint
#7806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
added
bug
eserilev
force-pushed
the
light_client_update_ssz_bug
branch
from
4c84840 to
8de9157
Compare
eserilev
added
ready-for-review
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
mergify
bot
added
ready-for-review
Comment on lines
849
to
859
| fn ssz_append(&self, buf: &mut Vec<u8>) { | ||
| buf.extend_from_slice(&self.response_chunk_len.to_le_bytes()); | ||
| buf.extend_from_slice(&self.response_chunk.context); | ||
| match &self.response_chunk.payload { | ||
| LightClientUpdate::Altair(lc) => lc.ssz_append(buf), | ||
| LightClientUpdate::Capella(lc) => lc.ssz_append(buf), | ||
| LightClientUpdate::Deneb(lc) => lc.ssz_append(buf), | ||
| LightClientUpdate::Electra(lc) => lc.ssz_append(buf), | ||
| LightClientUpdate::Fulu(lc) => lc.ssz_append(buf), | ||
| }; | ||
| } |
There was a problem hiding this comment.
This looks a bit sus to me, how does this differ from what derive generates?
There was a problem hiding this comment.
you're right, the match is exactly what derive generates. I cleaned things up a bit 67b45a9
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
jimmygchen
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#7759
Proposed Changes
We were incorrectly encoding the full response from
/light_client/updatesinstead of only encoding the light client updateAdditional Notes
This repo has a script that verifies light client data. I've used the repo to verify lc updates generated from both lodestar and lighthouse
https://github.com/eserilev/verify_light_client_update/tree/main